Project

General

Profile

Actions

Refactor #15525

closed

Fact-type specific host's last_compile time

Added by Ivan Necas almost 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Facts
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The last_compile time is right now global. Which means:

1. importing facts of one type would prevent importing facts of another type (see http://projects.theforeman.org/issues/15524 for specific case), due to https://github.com/theforeman/foreman/blob/1.11.3/app/models/host/base.rb#L142
2. the time of the fact might be wrong https://github.com/theforeman/foreman/blob/1.11.3/app/helpers/fact_values_helper.rb#L3, as the last_compile time is used
to show time of the fact.

We should probably make the last_compile a type-specific type so that they don't interfere with each other.


Related issues 1 (0 open1 closed)

Related to Katello - Bug #15524: Registering host with subscription-manager prevents loading puppet facts in subequent runRejectedIvan Necas06/27/2016Actions
Actions #1

Updated by Ivan Necas almost 8 years ago

  • Category set to Facts
Actions #2

Updated by Ivan Necas almost 8 years ago

  • Description updated (diff)
Actions #3

Updated by Ivan Necas almost 8 years ago

  • Related to Bug #15524: Registering host with subscription-manager prevents loading puppet facts in subequent run added
Actions #4

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Stephen Benjamin
  • Pull request https://github.com/theforeman/foreman/pull/3615 added
Actions #5

Updated by Stephen Benjamin almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #6

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release set to 161
Actions

Also available in: Atom PDF