Project

General

Profile

Actions

Bug #15308

closed

editing puppet class parameter with arrays and hashes fails when not overriding

Added by Ohad Levy almost 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

steps to reproduce:

a puppet class with either hash or array parameters, that override is false.

try to save:

always get an error message - "
"Override must be true to edit the parameter"


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #13727: Error not raised while setting default value when 'Override' set to False for parameter.ClosedOri Rabin02/16/2016Actions
Actions #1

Updated by Dominic Cleal almost 8 years ago

  • Related to Bug #13727: Error not raised while setting default value when 'Override' set to False for parameter. added
Actions #2

Updated by Dominic Cleal almost 8 years ago

  • Category set to Parameters
  • translation missing: en.field_release set to 136
Actions #3

Updated by Ori Rabin almost 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Ori Rabin
Actions #4

Updated by The Foreman Bot almost 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3573 added
Actions #5

Updated by Tomer Brisker almost 8 years ago

  • Bugzilla link set to 1343378
Actions #6

Updated by Tomer Brisker almost 8 years ago

note: this bug also prevents saving any smart class parameter without changes when viewing from the smart class parameter edit form.

Actions #7

Updated by Tomer Brisker almost 8 years ago

This fails in the class view only for array/hash values with inactive matchers, since the lookup value is changed (this is before it is parsed back into a ruby object - so it changes from object to string), causing the nested attribute to have nested_records_changed_for_autosave? set to true, and thus running the validation on it.

Actions #8

Updated by Ori Rabin almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF