Bug #15238

Multiple interfaces with empty identifier are marked as invalid

Added by Marek Hulán over 1 year ago. Updated 9 months ago.

Status:Closed
Priority:Normal
Assigned To:Marek Hulán
Category:Network
Target version:-
Difficulty: Bugzilla link:1406362
Found in release: Pull request:https://github.com/theforeman/foreman/pull/3560
Story points-
Velocity based estimate-
Release1.11.3Release relationshipAuto

Description

The NIC validation is not treating empty identifier correctly. While the validation method on host skips such interfaces, validation on NIC side tries to enforce uniqueness even of empty identifiers. This causes problems during provisioning of host with multiple interfaces, preventing the TFTP change because of interface being invalid. To reproduce, create a host with two interfaces with empty identifier. Then try editing the host, e.g. changing the comment attribute. It fails on interface identifier being already taken.


Related issues

Related to Foreman - Bug #12441: Duplicate entries in `nics` table Closed 11/10/2015

Associated revisions

Revision 7e20cbac
Added by Marek Hulán over 1 year ago

Fixes #15238 - ignore empty NIC identifiers

Revision dbf500fb
Added by Marek Hulán over 1 year ago

Fixes #15238 - ignore empty NIC identifiers

(cherry picked from commit 7e20cbac5951b858716268cce29f0fad16b71081)

Revision f6c83c4d
Added by Marek Hulán over 1 year ago

Fixes #15238 - ignore empty NIC identifiers

(cherry picked from commit 7e20cbac5951b858716268cce29f0fad16b71081)

History

#1 Updated by Marek Hulán over 1 year ago

  • Related to Bug #12441: Duplicate entries in `nics` table added

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3560 added

#3 Updated by Marek Hulán over 1 year ago

  • Release set to 1.11.3

the bug was introduced in 1.11 so marking for next 1.11 release, feel free to reset

#4 Updated by Marek Hulán over 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Marek Hulán about 1 year ago

  • Bugzilla link set to 1406362

Also available in: Atom PDF