Bug #14166: empty facet attributes not handled - "Creating a 'new host' fails for lifecycle_env and content_view saying "can't be blank" - Foreman

Actions

Copy link

Bug #14166

closed

empty facet attributes not handled - "Creating a 'new host' fails for lifecycle_env and content_view saying "can't be blank"

Added by Partha Aji about 8 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Partha Aji

Category:

Host creation

Target version:

1.11.1

Difficulty:

Triaged:

Bugzilla link:

1313431

Pull request:

https://github.com/theforeman/foreman/pull/3309

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1313431
Description of problem:

Creating a 'new host' fails for lifecycle_env and content_view saying "can't be blank", even though these values were set.

Version-Release number of selected component (if applicable):
Sat6.2.0-Beta-SNAP1

How reproducible:

Steps to Reproduce:
1. Create a "new host"
2. Provide "life-cycle env" and "content-view" values and also all the other needed values.
3. Click submit button.

Actual results:
To get a message "can't be blank" for "lifecycle-env" and "content-view".

Expected results:
"New host" page submission should be successful.
Additional info:

workaround: Again provide the values of "lifecycle-env" and "content-view".

Actions

Copy link

Updated by Partha Aji about 8 years ago

Project changed from Katello to Foreman
Category deleted (~~Hosts~~)

Actions

Copy link

Updated by Partha Aji about 8 years ago

Subject changed from Creating a 'new host' fails for lifecycle_env and content_view saying "can't be blank" to empty facet attributes not handled - "Creating a 'new host' fails for lifecycle_env and content_view saying "can't be blank"

The title is more of a symptom, but the root cause for this bug is this line in the upstream foreman.
https://github.com/theforeman/foreman/blob/develop/app/models/concerns/facets/managed_host_extensions.rb#L39

     def register_facet_relation(klass, facet_config)
        klass.class_eval do
          has_one facet_config.name, :class_name => facet_config.model.name, :foreign_key => :host_id, :inverse_of => :host
          accepts_nested_attributes_for facet_config.name, :update_only => true
          ...

Basically accepts_nested_attributes_for usage does not provide an easy way to include in a form without sending blank attributes

Actions

Copy link