Project

General

Profile

Actions

Feature #13417

closed

Wrap Facet registration in plugin API

Added by Eric Helms about 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin integration
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The current Facet registration for plugins occurs independently of registering and using the plugin interface. To me, this breaks from the idea of centralizing additions plugins need in the plugin API. Current registration:

  Facets.register(Katello::Host::ContentFacet, :content_facet) do
    api_view :list => 'katello/api/v2/content_facet/base_with_root', :single => 'katello/api/v2/content_facet/show'
  end

Related issues 1 (0 open1 closed)

Related to Foreman - Feature #12630: Facets - Add facet declarationClosedShimon Shtein11/30/2015Actions
Actions #1

Updated by Dominic Cleal about 8 years ago

Actions #2

Updated by Dominic Cleal about 8 years ago

  • Category set to Plugin integration
Actions #3

Updated by The Foreman Bot about 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Eric Helms
  • Pull request https://github.com/theforeman/foreman/pull/3134 added
Actions #4

Updated by Eric Helms about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal about 8 years ago

  • translation missing: en.field_release set to 71
Actions #6

Updated by Bryan Kearney about 8 years ago

  • Bugzilla link set to 1326034
Actions #7

Updated by Lukas Zapletal over 7 years ago

Stumbled upon this when I was reading Facet documentation.

http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin#Facets

Shall we remove the "This is being re-worked into a proper plugin API via #13417, it's highly recommended to use that when available and not use internal APIs." note?

Actions

Also available in: Atom PDF