Project

General

Profile

Actions

Bug #12618

closed

Compute profile overrides compute attributes provided in host form

Added by Marek Hulán over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Compute resources
Target version:
Fixed in Releases:
Found in Releases:

Description

If I select compute profile and in Virtual Machine tab I change some compute attr (e.g. image to be used or amount of RAM) it gets overiden by what's set in compute profile when I submit.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #12461: Compute profiles are not applied when inheritedClosedShimon Shtein11/12/2015Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2937 added
Actions #2

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #12461: Compute profiles are not applied when inherited added
Actions #3

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 63

This looks like a regression introduced by #12461, which calls set_compute_attributes from set_hostgroup_defaults without checking the value of compute_attributes.

Actions #4

Updated by Marek Hulán over 8 years ago

I think that call is required, after you select a hostgroup you need to refresh compute attributes from profile unconditionally. Maybe now we can even remove the condition from before_validation if it makes more sense. Anyway thanks for quick look.

Actions #5

Updated by The Foreman Bot over 8 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2957 added
Actions #6

Updated by Shimon Shtein over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF