Actions
Refactor #12099
closed
Template locked? relying on rake makes tests fail
Description
app/models/template.rb has a method locked? that relies on !Foreman.in_rake? to bypass the locked validation when running some operations through Rake such as migrations or cloning templates. On Rails 4 rake test is also interpreted as being 'in rake' and tests fail when running them through rake test but not when running template tests individually.
Updated by Daniel Lobato Garcia over 8 years ago
- Related to Tracker #3157: Rails 4.1 upgrade tasks added
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2797 added
- Pull request deleted (
)
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to Rejected
PR closed.
Updated by Dominic Cleal over 8 years ago
- Status changed from Rejected to Ready For Testing
- Assignee set to Daniel Lobato Garcia
- Pull request https://github.com/theforeman/foreman/pull/2834 added
- Pull request deleted (
https://github.com/theforeman/foreman/pull/2797)
New PR opened.
Updated by Dominic Cleal over 8 years ago
- translation missing: en.field_release set to 71
Updated by Daniel Lobato Garcia over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 1cff2424b89954a86e0a2d671db36526d958baab.
Actions