Project

General

Profile

Actions

Refactor #11618

closed

Replace validation tests by shoulda-matchers

Added by Daniel Lobato Garcia over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

A good chunk of our unit tests are testing whether a validation is working or not by testing it actively. For the validations we've added ourselves I would say it's fine. However for validations that come from the Rails framework, we're essentially testing their job. Instead of testing (for instance) validates(:name, :uniqueness => true) by creating two objects and verifying the second one won't save (these tests are already done at the framework level), we should simply test we're including validations in our models.

The well-maintained gem shoulda-matchers provide easy functions to check we're including such validations, and other helpers we can use to refactor our tests further and not test Rails functionality twice.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #13272: Basic edit test can fail when fixtures don't exist for a particular modelClosedStephen Benjamin01/19/2016Actions
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2651 added
  • Pull request deleted ()
Actions #2

Updated by Dominic Cleal over 8 years ago

  • translation missing: en.field_release set to 71
Actions #3

Updated by Daniel Lobato Garcia over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 8 years ago

  • Related to Bug #13272: Basic edit test can fail when fixtures don't exist for a particular model added
Actions

Also available in: Atom PDF