Project

General

Profile

Actions

Refactor #11323

closed

Refactor PID writing, interrupt trap and daemon logging

Added by Lukas Zapletal over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Core
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Currently, our deamonizing works as follows:

- initialize configuration, logger and plugins
- create http/https rack servers
- daemonize the main process
- start rack servers in own threads (each writes own pid file into same file)
- wait five seconds
- override interrupt signal trap
- wait for both threads to finish

Problems:

- Rack writes main process pid twice (the main process should do this on its own)
- pid file is written AFTER the main process exited (this is causing irregular warnings with systemd "not readable (yet?) after start")
- we should get rid of the 5 seconds sleep (what is this needed for)?
- when logging is setup to STDOUT it does not work (we need to error out when STDOUT is set and provide a way to configure foreman-proxy with syslog properly)


Related issues 5 (1 open4 closed)

Related to Smart Proxy - Bug #11653: stdout warning about use of "SYSLOG" logger on every startupClosed09/02/2015Actions
Related to Smart Proxy - Bug #11654: Error logged: Unable to overwrite interrupt trap: undefined method `version' for nil:NilClassClosed09/02/2015Actions
Related to Smart Proxy - Feature #676: Syslog supportResolved02/20/2011Actions
Related to Smart Proxy - Refactor #12402: Configure proxy with syslog by defaultNew11/05/2015Actions
Related to Smart Proxy - Bug #2174: Wrong log settings should have the proxy terminate on startupResolved02/03/2013Actions
Actions #1

Updated by Lukas Zapletal over 8 years ago

  • Subject changed from Refactor proxy daemonizing code to Refactor PID writing, interrupt trap and daemon logging
Actions #2

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/311 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal over 8 years ago

  • Category set to Core
  • translation missing: en.field_release set to 63
Actions #4

Updated by Anonymous over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #11653: stdout warning about use of "SYSLOG" logger on every startup added
Actions #6

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #11654: Error logged: Unable to overwrite interrupt trap: undefined method `version' for nil:NilClass added
Actions #7

Updated by Lukas Zapletal over 8 years ago

Actions #8

Updated by Lukas Zapletal over 8 years ago

Actions #9

Updated by Anonymous almost 8 years ago

  • Related to Bug #2174: Wrong log settings should have the proxy terminate on startup added
Actions

Also available in: Atom PDF