Project

General

Profile

Actions

Bug #10535

closed

Tokens are created for managed hosts after validation

Added by Ori Rabin almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Host creation
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

set_token is called fr managed host after validations and not after save.
This can't be moved to after_save since the token is needed before save for templates.
The result is a token can be created for a host that eventually isn't saved as a managed host.
I only reproduced this with discovery: http://projects.theforeman.org/issues/9597
when provisioning a discovered host, trying to save causes validations and then a token was created.
As a result after canceling there was a token connected to a discovered host.


Related issues 3 (0 open3 closed)

Related to Discovery - Bug #9597: FK violation when trying to delete a discovered host after provisionClosedOri Rabin03/01/2015Actions
Related to Foreman - Bug #10558: Remove and prevent duplicate tokens via DB migrationClosedOri Rabin05/20/2015Actions
Has duplicate Foreman - Bug #10645: ERROR: update or delete on table "hosts" violates foreign key constraint "tokens_host_id_fk" on table "tokens" DETAIL: Key (id)=(2) is still referenced from table "tokens". Duplicate05/28/2015Actions
Actions #1

Updated by Ori Rabin almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #2

Updated by Lukas Zapletal almost 9 years ago

If this bug is planned to be backported into 1.8, we need to make sure that Discovery migration is copied over into Foreman core. See the PR discussion for more info.

Actions #3

Updated by Dominic Cleal almost 9 years ago

  • Category set to Host creation
  • translation missing: en.field_release set to 35
Actions #4

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #9597: FK violation when trying to delete a discovered host after provision added
Actions #5

Updated by Dominic Cleal almost 9 years ago

Lukas Zapletal wrote:

If this bug is planned to be backported into 1.8, we need to make sure that Discovery migration is copied over into Foreman core. See the PR discussion for more info.

It needs moving or copying either way, #10558.

Actions #6

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #10558: Remove and prevent duplicate tokens via DB migration added
Actions #7

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release changed from 35 to 56
Actions #8

Updated by Dominic Cleal almost 9 years ago

  • Has duplicate Bug #10645: ERROR: update or delete on table "hosts" violates foreign key constraint "tokens_host_id_fk" on table "tokens" DETAIL: Key (id)=(2) is still referenced from table "tokens". added
Actions

Also available in: Atom PDF