Project

General

Profile

Actions

Bug #10343

closed

ActiveRecord::RecordNotSaved creating settings when Rails cache not functional

Added by Dominic Cleal almost 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Settings
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When using foreman_memcache and it's unconfigured and not functional, then a new setting is added (e.g. installing a new plugin), app startup simply fails with "ActiveRecord::RecordNotSaved".

To reproduce, install foreman_memcache and another plugin which adds settings, then Foreman should fail to start.

Rails.cache.delete returns 'false' when the cache isn't functional. The Setting#clear_cache before_save callback then calls cache.delete, returning the result. This causes the saving of the setting to fail entirely.

Actions #1

Updated by Dominic Cleal almost 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Dominic Cleal
Actions #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2344 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release set to 50
Actions

Also available in: Atom PDF